Re: min_safe_lsn column in pg_replication_slots view
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-06-20T06:53:54Z
Lists: pgsql-hackers
On Sat, Jun 20, 2020 at 09:45:52AM +0530, Amit Kapila wrote: > On Sat, Jun 20, 2020 at 7:12 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote: >> I don't disagree with removing the LSN column, but at the same time we >> need to provide *some* way for users to monitor this, so let's add a >> function to extract the value they need for that. It seems simple >> enough. > > Isn't this information specific to checkpoints, so maybe better to > display in view pg_stat_bgwriter? Not sure that's a good match. If we decide to expose that, a separate function returning a LSN based on the segment number from XLogGetLastRemovedSegno() sounds fine to me, like pg_wal_last_recycled_lsn(). Perhaps somebody has a better name in mind? -- Michael
Commits
-
Fix uninitialized value in segno calculation
- b5b4c0fef9fb 14.0 landed
- 794e8e32bb5a 13.0 landed
-
Morph pg_replication_slots.min_safe_lsn to safe_wal_size
- c54b5891f415 13.0 landed
- a8aaa0c786b3 14.0 landed