Re: min_safe_lsn column in pg_replication_slots view
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, amit.kapila16@gmail.com, pgsql-hackers@postgresql.org
Date: 2020-06-20T01:42:23Z
Lists: pgsql-hackers
On 2020-Jun-19, Michael Paquier wrote: > If we want to make this happen, I am afraid that the time is short as > beta2 is planned for next week. As the version will be likely tagged > by Monday US time, it would be good to get this addressed within 48 > hours to give some room to the buildfarm to react. Attached is a > straight-forward proposal of patch. Any thoughts? I don't disagree with removing the LSN column, but at the same time we need to provide *some* way for users to monitor this, so let's add a function to extract the value they need for that. It seems simple enough. I cannot implement it myself now, though. I've reached the end of my week and I'm not sure I'll be able to work on it during the weekend. I agree with Kyotaro's opinion that the pg_walfile_name() function seems too single-minded ... -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix uninitialized value in segno calculation
- b5b4c0fef9fb 14.0 landed
- 794e8e32bb5a 13.0 landed
-
Morph pg_replication_slots.min_safe_lsn to safe_wal_size
- c54b5891f415 13.0 landed
- a8aaa0c786b3 14.0 landed