Horton

Re: Add support for INDEX_CLEANUP and TRUNCATE to vacuumdb

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "masao.fujii@gmail.com" <masao.fujii@gmail.com>, Andres Freund <andres@anarazel.de>, Masahiko Sawada <sawada.mshk@gmail.com>, "euler@timbira.com.br" <euler@timbira.com.br>
Date: 2020-06-19T01:57:01Z
Lists: pgsql-hackers 
On Thu, Jun 18, 2020 at 09:26:50PM +0000, Bossart, Nathan wrote:
> It looks like I missed a couple of tags in the documentation changes.
> That should be fixed in v3.

Thanks.  This flavor looks good to me in terms of code, and the test
coverage is what's needed for all the code paths added.  This version
is using my suggestion of upthread for the option names: --no-truncate
and --no-index-cleanup.  Are people fine with this choice?
--
Michael

Commits

  1. Add --no-index-cleanup and --no-truncate to vacuumdb.