Horton

Re: Physical replication slot advance is not persistent

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, andres@anarazel.de, dim@tapoueh.org, pgsql-hackers@postgresql.org, simon@2ndquadrant.com
Date: 2020-06-18T07:47:46Z
Lists: pgsql-hackers 
On Tue, Jun 16, 2020 at 04:27:27PM +0900, Michael Paquier wrote:
> We could do that.  Now I found cleaner the direct comparison of
> pg_replication_slots.restart before and after the restart.  So I have
> kept it.

And done.  There were conflicts in 001_stream_rep.pl for 11 and 12 but
I have reworked the patch on those branches to have a minimum amount
of diffs with the other branches.  This part additionally needed to
stop standby_1 before running the last part of the test to be able to
drop its physical slot on the primary.
--
Michael

Commits

  1. Fix oldest xmin and LSN computation across repslots after advancing

  2. Fix slot data persistency when advancing physical replication slots