Re: min_safe_lsn column in pg_replication_slots view
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Date: 2020-06-15T04:44:31Z
Lists: pgsql-hackers
On Mon, Jun 15, 2020 at 12:40:03PM +0900, Fujii Masao wrote: > BTW, I just wonder why each row in pg_replication_slots needs to have > min_safe_lsn column? Basically min_safe_lsn should be the same between > every replication slots. Indeed, that's confusing in its current shape. I would buy putting this value into pg_replication_slots if there were some consistency of the data to worry about because of locking issues, but here this data is controlled within info_lck, which is out of the the repslot LW lock. So I think that it is incorrect to put this data in this view and that we should remove it, and that instead we had better push for a system view that maps with the contents of XLogCtl. -- Michael
Commits
-
Fix uninitialized value in segno calculation
- b5b4c0fef9fb 14.0 landed
- 794e8e32bb5a 13.0 landed
-
Morph pg_replication_slots.min_safe_lsn to safe_wal_size
- c54b5891f415 13.0 landed
- a8aaa0c786b3 14.0 landed