Horton

Re: doc review for v13

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, James Coleman <jtc331@gmail.com>, pgsql-hackers@lists.postgresql.org, Alexander Korotkov <a.korotkov@postgrespro.ru>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Date: 2020-06-12T07:48:32Z
Lists: pgsql-hackers 
On Thu, Jun 11, 2020 at 09:37:09PM -0500, Justin Pryzby wrote:
> Some new bits,
> And some old ones.

I was looking at this patch set, and 0005 has attracted my attention
here:

> --- a/src/backend/utils/cache/relcache.c
> +++ b/src/backend/utils/cache/relcache.c
> @@ -4240,7 +4240,6 @@ AttrDefaultFetch(Relation relation)
>  	HeapTuple	htup;
>  	Datum		val;
>  	bool		isnull;
> -	int			found;
>  	int			i;

Since 16828d5, this variable is indeed unused.  Now, the same commit
has removed the following code:
-   if (found != ndef)
-       elog(WARNING, "%d attrdef record(s) missing for rel %s",
-            ndef - found, RelationGetRelationName(relation));

Should we actually keep this variable and have this sanity check in
place?  It seems to me that it would be good to have that, so as we
can make sure that the number of default attributes cached matches
with the number of defaults actually found when scanning each
attribute.  Adding in CC Andrew as the author of 16828d5 for more
input.
--
Michael

Commits

  1. Copy editing: fix a bunch of misspellings and poor wording.

  2. doc: Fix some grammar and inconsistencies

  3. Fix some comments referring to past features

  4. Fix typos and some format mistakes in comments

  5. Fix some typos

  6. Fix collection of typos and grammar mistakes in the tree, volume 2

  7. Rename pg_validatebackup to pg_verifybackup.

  8. Fix collection of typos and grammar mistakes in the tree