pg_dump, gzwrite, and errno
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: pgsql-hackers@postgresql.org
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Kunshchikov Vladimir <Vladimir.Kunshchikov@infotecs.ru>
Date: 2020-06-11T15:37:53Z
Lists: pgsql-hackers
While testing Pavel's patch for pg_dump --filter, I got:
pg_dump: error: could not write to output file: Success
[pryzbyj@database postgresql]$ echo $?
1
I see we tried to fix it few years ago:
https://www.postgresql.org/message-id/flat/1498120508308.9826%40infotecs.ru
https://www.postgresql.org/message-id/flat/20160125143008.2539.2878%40wrigleys.postgresql.org
https://www.postgresql.org/message-id/20160307.174354.251049100.horiguchi.kyotaro@lab.ntt.co.jp
https://www.postgresql.org/message-id/20150608174336.GM133018@postgresql.org
Commits:
4d57e83816778c6f61ea35c697f937a6f9c3c3de
9a3b5d3ad0f1c19c47e2ee65b372344cb0616c9a
This patch fixes it for me
pg_dump: error: could not write to output file: No space left on device
--- a/src/bin/pg_dump/pg_backup_directory.c
+++ b/src/bin/pg_dump/pg_backup_directory.c
@@ -347,8 +347,12 @@ _WriteData(ArchiveHandle *AH, const void *data, size_t dLen)
lclContext *ctx = (lclContext *) AH->formatData;
if (dLen > 0 && cfwrite(data, dLen, ctx->dataFH) != dLen)
+ {
+ if (errno == 0)
+ errno = ENOSPC;
fatal("could not write to output file: %s",
get_cfp_error(ctx->dataFH));
+ }
}
PS. Due to $UserError, I originally sent this message with inaccurate RFC822
headers..
Commits
-
Ensure write failure reports no-disk-space
- e74559c97630 13.0 landed
- ae3259c55067 14.0 landed
- 83762d0a928d 9.6.19 landed
- 5b52008a6441 12.4 landed
- 411febd53e99 10.14 landed
- 2e155d90d1b8 11.9 landed
- bbbce94dc262 9.5.23 landed
-
Fix build on zlib-less environments
- 9a3b5d3ad0f1 10.0 cited
-
Fix pg_dump's errno checking for zlib I/O
- 4d57e8381677 10.0 cited