Re: REINDEX CONCURRENTLY and indisreplident

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Euler Taveira <euler.taveira@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-06-05T02:04:39Z
Lists: pgsql-hackers
On Thu, Jun 04, 2020 at 11:23:36AM +0900, Michael Paquier wrote:
> On Wed, Jun 03, 2020 at 12:40:38PM -0300, Euler Taveira wrote:
> > On Wed, 3 Jun 2020 at 03:54, Michael Paquier <michael@paquier.xyz> wrote:
> >> I have bumped into $subject, causing a replica identity index to
> >> be considered as dropped if running REINDEX CONCURRENTLY on it.  This
> >> means that the old tuple information would get lost in this case, as
> >> a REPLICA IDENTITY USING INDEX without a dropped index is the same as
> >> NOTHING.
> >
> > LGTM. I tested in both versions (12, master) and it works accordingly.
> 
> Thanks for the review.  I'll try to get that fixed soon.

Applied this one, just in time before the branching:
https://www.postgresql.org/message-id/1931934b-09dc-e93e-fab9-78c5bc72743d@postgresql.org
--
Michael

Commits

  1. Preserve pg_index.indisreplident across REINDEX CONCURRENTLY