Re: Missing grammar production for WITH TIES

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Vik Fearing <vik@postgresfriends.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-05-19T06:20:29Z
Lists: pgsql-hackers
On Tue, May 19, 2020 at 12:41:39AM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> This has been committed just after beta1 has been stamped.  So it
>> means that it won't be included in it, right?
> 
> Right.

Still, wouldn't it be better to wait until the version is tagged?  My
understanding is that we had better not commit anything on a branch
planned for release between the moment the version is stamped and the
moment the tag is pushed so as we have a couple of days to address any
complaints from -packagers.  Here, we are in a state where we have
between the stamp time and tag time an extra commit not related to a
packaging issue.  So, if it happens that we have an issue from
-packagers to address, then we would have to include c301c2e in the
beta1.  Looking at the patch committed, that's not much of an issue,
but I think that we had better avoid that.
--
Michael

Commits

  1. WITH TIES: number of rows is optional and defaults to one