Re: pg_stat_wal_receiver and flushedUpto/writtenUpto
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2020-05-15T17:43:11Z
Lists: pgsql-hackers
On 2020-May-15, Michael Paquier wrote: > As discussed in the thread that introduced d140f2f3 to rename > receivedUpto to flushedUpto and add writtenUpto to the WAL receiver's > shared memory information, the equivalent columns in > pg_stat_wal_receiver have not been renamed: > When I have implemented this system view, the idea was to keep a > one-one mapping between the SQL interface and the shmem info even if > we are not compatible with past versions, hence I think that before > beta1 we had better fix that and: > - rename received_lsn to flushed_lsn. > - add one column for writtenUpto. Why do you put the column at the end? I would put written_lsn before flushed_lsn. Since this requires a catversion bump, I think it'd be best to do it before beta1 next week. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Doc: Replace reference to pg_stat_wal_receiver.received_lsn by flushed_lsn
- a56e7046d6f2 13.0 landed
-
Make pg_stat_wal_receiver consistent with the WAL receiver's shmem info
- 2c8dd05d6cbc 13.0 landed