Horton

Re: Add "-Wimplicit-fallthrough" to default flags

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andy Fan <zhihui.fan1213@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-05-13T15:23:57Z
Lists: pgsql-hackers 
On 2020-May-13, Tom Lane wrote:

> Andy Fan <zhihui.fan1213@gmail.com> writes:
> >> FWIW, I got a warning for jsonpath_gram.c.
> 
> Ugh.  Confirmed here on Fedora 30 (bison 3.0.5).

Ugh.

> > I just found this just serval minutes ago.  Upgrading your bison to the
> > latest version (3.6) is ok. I'd like we have a better way to share this
> > knowledge through.  I spend ~30 minutes to troubleshooting this issue.
> 
> I fear that is going to mean that we revert this patch.

Or we can filter-out the -Wimplicit-fallthrough, or change to level 3,
for bison-emitted files.


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Dial back -Wimplicit-fallthrough to level 3

  2. Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS

  3. Suppress -Wimplicit-fallthrough warning in new LIMIT WITH TIES code.

  4. Support FETCH FIRST WITH TIES