Horton

Re: [PATCH] Incremental sort (was: PoC: Partial sort)

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Justin Pryzby <pryzby@telsasoft.com>, James Coleman <jtc331@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Rafia Sabih <rafia.pghackers@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, Shaun Thomas <shaun.thomas@2ndquadrant.com>, Dmitry Dolgov <9erthalion6@gmail.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Andreas Karlsson <andreas@proxel.se>
Date: 2020-05-12T18:18:07Z
Lists: pgsql-hackers 
On Sun, May 10, 2020 at 02:25:23PM +0200, Tomas Vondra wrote:
>On Sat, May 09, 2020 at 06:48:02PM -0700, Peter Geoghegan wrote:
>>On Sat, May 9, 2020 at 3:19 PM Tomas Vondra
>><tomas.vondra@2ndquadrant.com> wrote:
>>>I'm generally OK with most of this - I'd probably keep the single-line
>>>format, but I don't feel very strongly about that and if others think
>>>using two lines is better ...
>>>
>>>Barring objections I'll get this polished and pushed soon-ish (say,
>>>early next week).
>>
>>I see something about starting a new thread on the Open Items page.
>>Please CC me on this.
>>
>>Speaking in my capacity as an RMT member: Glad to see that you plan to
>>close this item out next week. (I had planned on giving you a nudge
>>about this, but it looks like I don't really have to now.)
>>
>
>Not sure about about the new thread - the discussion continues on the
>main incremental sort thread, I don't see any proposal to start a new
>thread there. IMO it'd be pointless at this point.
>

I've pushed both patches, fixing typos and explain format.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Further adjustments to Hashagg EXPLAIN ANALYZE output

  2. Rework EXPLAIN format for incremental sort

  3. Fix typos and improve incremental sort comments

  4. Stabilize incremental_sort tests

  5. Minor improvements in Incremental Sort explain

  6. Consider Incremental Sort paths at additional places

  7. Fix representation of SORT_TYPE_STILL_IN_PROGRESS.

  8. Fix failures in incremental_sort due to number of workers

  9. Fix show_incremental_sort_info with force_parallel_mode

  10. Implement Incremental Sort

  11. Fix handling of "Subplans Removed" field in EXPLAIN output.

  12. Fix EXPLAIN (SETTINGS) to follow policy about when to print empty fields.

  13. Ensure plpgsql result tuples have the right composite type marking.

  14. Propagate sort instrumentation from workers back to leader.

  15. Make new regression test case parallel-safe, and improve its output.

  16. Push limit through subqueries to underlying sort, where possible.

  17. Fix inappropriate printing of never-measured times in EXPLAIN.

  18. Fix some infelicities in EXPLAIN output for parallel query plans.