Horton

Re: Postgres Windows build system doesn't work with python installed in Program Files

Victor Wagner <vitus@wagner.pp.ru>

View thread View on postgr.es
From: Victor Wagner <vitus@wagner.pp.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-05-05T07:16:23Z
Lists: pgsql-hackers 
В Tue, 5 May 2020 15:45:48 +0900
Michael Paquier <michael@paquier.xyz> пишет:

> On Fri, May 01, 2020 at 12:48:17PM +0300, Victor Wagner wrote:
> > Maybe. But probably original author of this code was afraid of using
> > too long chain of ->{} in the string substitution. 
> > 
> > So, I left this style n place.
> > 
> > Nonetheless, using qq wouldn't save us from doubling backslashes.  
> 
> Looking at this part in more details, I find the attached much more
> readable.  I have been able to test it on my own Windows environment

I agree, it is better.


> and the problem gets fixed (I have reproduced the original problem as
> well).
--

Commits

  1. Improve perl script in MSVC to build binaries

  2. Handle spaces for Python install location in MSVC scripts

  3. Use perl's $/ more idiomatically