Horton

Re: implicit declaration of datumIsEqual in parse_coerce.c

Noah Misch <noah@leadboat.com>

View thread View on postgr.es
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2020-05-03T06:48:36Z
Lists: pgsql-hackers 
On Tue, Apr 07, 2020 at 10:39:30PM -0400, Tom Lane wrote:
> > On Tue, Apr 07, 2020 at 05:16:58PM -0400, Tom Lane wrote:
> >> That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably
> >> explains why most of us aren't seeing it.  My guess is somebody
> >> removed an #include without realizing that this chunk of code
> >> needed it.

> Curiously, there are no buildfarm warnings about this, even though we have
> at least one member running with RANDOMIZE_ALLOCATED_MEMORY.  Wonder why?

The RANDOMIZE_ALLOCATED_MEMORY buildfarm members use xlc, which disables this
warning by default.  (Given flag -qinfo=pro, it would warn.)

Commits

  1. Put back mistakenly removed #include.

  2. Restructure polymorphic-type resolution in funcapi.c.