Re: SLRU statistics

Tomas Vondra <tomas.vondra@2ndquadrant.com>

From: Tomas Vondra <tomas.vondra@2ndquadrant.com>

To: Fujii Masao <masao.fujii@oss.nttdata.com>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2020-05-02T00:08:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix async.c to not register any SLRU stats counts in the postmaster.
- 7fd89f4d7a51 13.0 landed
Use proper GetDatum function in pg_stat_get_slru().
- 043e3e040160 13.0 landed
Initialize SLRU stats entries to zero.
- f3d23d83ef9a 13.0 landed
Remove pg_xact from pg_stat_reset_slru docs
- e685ca63ca4f 13.0 landed
Remove pg_xact entry from SLRU stats
- 2e08d314ed07 13.0 landed
Track SLRU page hits in SimpleLruReadPage_ReadOnly
- 2b88fdde30d8 13.0 landed
Fix typo in SLRU stats documentation
- 2c220ca46f3f 13.0 landed
Collect statistics about SLRU caches
- 28cac71bd368 13.0 landed
Simplify and rename some GUC variables, per various recent discussions:
- 48f7e6439568 8.3.0 cited

On Fri, May 01, 2020 at 11:49:51AM +0900, Fujii Masao wrote:
>
>
>On 2020/05/01 3:19, Tomas Vondra wrote:
>>On Fri, May 01, 2020 at 03:02:59AM +0900, Fujii Masao wrote:
>>>
>>>
>>>On 2020/04/02 9:41, Tomas Vondra wrote:
>>>>Hi,
>>>>
>>>>I've pushed this after some minor cleanup and improvements.
>>>
>>>+static char *slru_names[] = {"async", "clog", "commit_timestamp",
>>>+                              "multixact_offset", "multixact_member",
>>>+                              "oldserxid", "pg_xact", "subtrans",
>>>+                              "other" /* has to be last */};
>>>
>>>When I tried pg_stat_slru, I found that it returns a row for "pg_xact".
>>>But since there is no "pg_xact" slru ("clog" slru exists instead),
>>>"pg_xact" should be removed? Patch attached.
>>>
>>
>>Yeah, I think I got confused and accidentally added both "clog" and
>>"pg_xact". I'll get "pg_xact" removed.
>
>Thanks!
>

OK, pushed. Thanks!

>Another thing I found is; pgstat_send_slru() should be called also by
>other processes than backend? For example, since clog data is flushed
>basically by checkpointer, checkpointer seems to need to send slru stats.
>Otherwise, pg_stat_slru.flushes would not be updated.
>

Hmmm, that's a good point. If I understand the issue correctly, the
checkpointer accumulates the stats but never really sends them because
it never calls pgstat_report_stat/pgstat_send_slru. That's only called
from PostgresMain, but not from CheckpointerMain.

I think we could simply add pgstat_send_slru() right after the existing
call in CheckpointerMain, right?

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services