Horton

Re: Postgres Windows build system doesn't work with python installed in Program Files

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Victor Wagner <vitus@wagner.pp.ru>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-05-01T08:52:15Z
Lists: pgsql-hackers 
On Thu, Apr 30, 2020 at 03:06:08PM +0300, Victor Wagner wrote:
> Fix is very simple, see attach.
> 
> Patch is made against REL_12_STABLE, but probably applicable to other
> versions as well.

Indeed, thanks.

>  		my $pythonprog = "import sys;print(sys.prefix);"
>  		  . "print(str(sys.version_info[0])+str(sys.version_info[1]))";
>  		my $prefixcmd =
> -		  $solution->{options}->{python} . "\\python -c \"$pythonprog\"";
> +		'"' . $solution->{options}->{python} . "\\python\" -c \"$pythonprog\"";
>  		my $pyout = `$prefixcmd`;
>  		die "Could not query for python version!\n" if $?;
>  		my ($pyprefix, $pyver) = split(/\r?\n/, $pyout);

This reminds me of ad7595b.  Wouldn't it be better to use qq() here?
--
Michael

Commits

  1. Improve perl script in MSVC to build binaries

  2. Handle spaces for Python install location in MSVC scripts

  3. Use perl's $/ more idiomatically