Re: Remove unnecessary relabel stripping
Tomas Vondra <tomas.vondra@2ndquadrant.com>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-04-30T00:11:02Z
Lists: pgsql-hackers
On Wed, Apr 29, 2020 at 03:51:40PM +0800, Richard Guo wrote: >Hi hackers, > >Per discussion in [1], we don't need to strip relabel for the expr >explicitly before calling pull_varnos() to retrieve all mentioned >relids. pull_varnos() would recurse into T_RelabelType nodes. > >Add a patch to remove that and simplify the code a bit. > >[1] >https://www.postgresql.org/message-id/flat/CAMbWs48HF9f%3Dg%2BjSmmYBnWub9%2BWyg5Xh-FoqAnvqAspue5ypAw%40mail.gmail.com#b6e77e4c1ae67e2c5d97dce830b58037 > >Thanks >Richard Thanks, I'll get this pushed (or something similar to this patch) soon. FWIW it'd be better to send the patch to the original thread instead of starting a new one. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Simplify cost_incremental_sort a bit
- 60fbb4d76250 13.0 landed