Re: doc review for v13
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: James Coleman <jtc331@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Alexander Korotkov <a.korotkov@postgrespro.ru>
Date: 2020-04-27T06:03:05Z
Lists: pgsql-hackers
On Sun, Apr 26, 2020 at 08:59:05PM -0400, Tom Lane wrote: > James Coleman <jtc331@gmail.com> writes: >> On Sun, Apr 26, 2020 at 12:13 PM Justin Pryzby <pryzby@telsasoft.com> wrote: >>> I think my text is correct. This would *also* be correct: >>> | If any <literal>CHECK</literal> constraint on the table being >>> | attached is marked <literal>NO INHERIT</literal>, the command will fail; >>> But not the hybrid: "If any OF THE .. is .." > >> "any of the...are" sounds more natural to my ears, > > Yeah, I think the same. If you want to argue grammar, I'd point > out that the "any" could refer to several of the constraints, > making it correct to use the plural verb. The alternative that > Justin mentions could be written as "If any one constraint is ...", > which is correct in that form; but the plural way seems less stilted. Hm, okay. There are still pieces in those patches about which I am not sure, so I have let that aside for the time being. Anyway, I have applied patch 12, and reported the typos from imath.c directly to upstream: https://github.com/creachadair/imath/issues/45 https://github.com/creachadair/imath/issues/46 -- Michael
Commits
-
Copy editing: fix a bunch of misspellings and poor wording.
- e62c5ea22c12 13.0 landed
- 9436041ed848 14.0 landed
-
doc: Fix some grammar and inconsistencies
- a4c0dbc447c7 9.6.20 landed
- d56d33052183 10.15 landed
- 447c1cb2f67f 11.10 landed
- 25ff747721a5 12.5 landed
- b3d89b7a8896 13.0 landed
- aad546bd0a51 14.0 landed
-
Fix some comments referring to past features
- 7a3543c2ea23 14.0 landed
-
Fix typos and some format mistakes in comments
- aaf8c990502f 14.0 landed
-
Fix some typos
- 641b76d9d12f 13.0 landed
-
Fix collection of typos and grammar mistakes in the tree, volume 2
- 8128b0c152a6 13.0 landed
-
Rename pg_validatebackup to pg_verifybackup.
- dbc60c5593f2 13.0 cited
-
Fix collection of typos and grammar mistakes in the tree
- dd0f37eccecc 13.0 landed