Horton

Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Amit Langote <amitlangote09@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-04-21T15:45:53Z
Lists: pgsql-hackers 
On 2020-Apr-20, Alvaro Herrera wrote:

> +	while (HeapTupleIsValid(trigtup = systable_getnext(scan)))
> +	{
> +		Form_pg_trigger pg_trigger = (Form_pg_trigger) GETSTRUCT(trigtup);
> +		ObjectAddress trig;
> +
> +		/* Ignore triggers that weren't cloned */
> +		if (!OidIsValid(pg_trigger->tgparentid) ||
> +			!pg_trigger->tgisinternal ||
> +			!TRIGGER_FOR_ROW(pg_trigger->tgtype))
> +			continue;

Actually, shouldn't we be checking just "!OidIsValid(pg_trigger->tgparentid)"
here?  Surely the other two conditions should already not matter either
way if tgparentid is set.  I can't see us starting to clone
for-statement triggers, but I'm not sure I trust the internal marking to
remain one way or the other.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. psql \d: Display table where trigger is defined, if inherited

  2. Document partitiong tables ancillary object handling some more

  3. Fix detaching partitions with cloned row triggers