Re: fixing old_snapshot_threshold's time->xid mapping
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Kevin Grittner <kgrittn@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-04-18T20:17:15Z
Lists: pgsql-hackers
Hi, On 2020-04-17 14:12:44 +1200, Thomas Munro wrote: > What about a contrib function that lets you clobber > oldSnapshotControl->current_timestamp? It looks like all times in > this system come ultimately from GetSnapshotCurrentTimestamp(), which > uses that variable to make sure that time never goes backwards. It'd be better than the current test situation, and probably would be good to have as part of testing anyway (since it'd allow to make the tests not take long / be racy on slow machines). But I still don't think it really allows to test the feature in a natural way. It makes it easier to test for know edge cases / problems, but not really discover unknown ones. For that I think we need more granular bins. - Andres
Commits
-
Remove the "snapshot too old" feature.
- f691f5b80a85 17.0 landed
-
Fix two bugs in MaintainOldSnapshotTimeMapping.
- 55b7e2f4d78d 14.0 landed
-
Add new 'old_snapshot' contrib module.
- aecf5ee2bb36 14.0 landed
-
Expose oldSnapshotControl definition via new header.
- f5ea92e8d620 14.0 landed