Re: BUG #16369: Segmentation Faults and Data Corruption with Generated Columns

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, cameron.ezell@clearcapital.com, pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2020-04-18T09:28:56Z
Lists: pgsql-bugs
On Sat, Apr 18, 2020 at 02:13:17PM +1200, David Rowley wrote:
> On Thu, 16 Apr 2020 at 17:30, Michael Paquier <michael@paquier.xyz> wrote:
> > Shouldn't you have more regression test cases here?  I guess one for
> > the non-NULL case, and one for the NULL case?
> 
> Yeah. I've just pushed a fix that included a fairly simple regression test.

Thanks for the commit, David!  I was wondering if it would have been
better to add a "\pset null", but that's a nit and the result looks
fine anyway.
--
Michael

Commits

  1. Fix possible crash with GENERATED ALWAYS columns