Horton

Re: cleaning perl code

Garick Hamlin <ghamlin@isc.upenn.edu>

View thread View on postgr.es
From: "Hamlin, Garick L" <ghamlin@isc.upenn.edu>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Noah Misch <noah@leadboat.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-04-16T14:20:53Z
Lists: pgsql-hackers 
On Thu, Apr 16, 2020 at 08:50:35AM -0400, Andrew Dunstan wrote:
> 
> It would also be more robust using non-greedy matching:

This seems more important.
I don't know how/where this is being used, but if it has input like:

/* one */ 
something;
/* two */

With the old expression 'something;' would be stripped away.  
Is that an issue where this this is used?  Why are we parsing
these headers?

Garick

Commits

  1. Stop requiring an explicit return from perl subroutines

  2. Use perl's $/ more idiomatically

  3. Use perl warnings pragma consistently