Re: Race condition in SyncRepGetSyncStandbysPriority
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: masahiko.sawada@2ndquadrant.com
Cc: tgl@sss.pgh.pa.us, masao.fujii@oss.nttdata.com,
pgsql-hackers@lists.postgresql.org
Date: 2020-04-16T09:26:26Z
Lists: pgsql-hackers
Attachments
- syncrep-fixes-4.patch (text/x-patch) patch
At Thu, 16 Apr 2020 16:48:28 +0900, Masahiko Sawada <masahiko.sawada@2ndquadrant.com> wrote in > This is just a notice; I'm reading your latest patch but it seems to > include unrelated changes: > > $ git diff --stat > src/backend/replication/syncrep.c | 475 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------------------------------------------- > src/backend/replication/walsender.c | 40 ++++++++++++++----- > src/bin/pg_dump/compress_io.c | 12 ++++++ > src/bin/pg_dump/pg_backup_directory.c | 48 ++++++++++++++++++----- > src/include/replication/syncrep.h | 20 +++++++++- > src/include/replication/walsender_private.h | 16 ++++---- > 6 files changed, 274 insertions(+), 337 deletions(-) Ugg. I failed to clean up working directory.. I didn't noticed as I made the file by git diff. Thanks for noticing me of that. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Fix race conditions in synchronous standby management.
- c65c1aa82105 9.6.18 landed
- f332241a60aa 13.0 landed
- b3fa6d016d82 11.8 landed
- 63ecdaf758c5 10.13 landed
- 00ef5d52c577 12.3 landed
-
When WalSndCaughtUp, sleep only in WalSndWaitForWal().
- 421685812290 13.0 cited