Re: documenting the backup manifest file format
Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Try to avoid compiler warnings in optimized builds.
- 05021a2c0cd2 13.0 landed
-
Fix option related issues in pg_verifybackup.
- 0a89e93bfaa6 13.0 landed
-
Add index term for backup manifest in documentation.
- 4db819ba4039 13.0 landed
-
Code review for backup manifest.
- a2ac73e7be7a 13.0 landed
-
Document the backup manifest file format.
- 149f2ae88ab0 13.0 landed
-
Fix typo in pg_validatebackup documentation.
- c4f82a779d26 13.0 landed
-
Exclude backup_manifest file that existed in database, from BASE_BACKUP.
- 1ec50a81ec0a 13.0 landed
-
Msys2 tweaks for pg_validatebackup corruption test
- c3e4cbaab936 13.0 landed
-
Fix resource management bug with replication=database.
- 3e0d80fd8d3d 13.0 cited
-
Be more careful about time_t vs. pg_time_t in basebackup.c.
- db1531cae009 13.0 cited
-
pg_validatebackup: Fix 'make clean' to remove tmp_check.
- 9f8f881caa0f 13.0 landed
-
pg_validatebackup: Also use perl2host in TAP tests.
- 460314db08e8 13.0 landed
-
Generate backup manifests for base backups, and validate them.
- 0d8c9c1210c4 13.0 landed
-
Add checksum helper functions.
- c12e43a2e0d4 13.0 landed
-
pg_waldump: Add a --quiet option.
- ac44367efbef 13.0 landed
-
Catversion bump for b9b408c48724
- afb5465e0cfc 13.0 cited
-
pg_basebackup: Refactor code for reading COPY and tar data.
- 431ba7bebf13 13.0 landed
-
Use a ResourceOwner to track buffer pins in all cases.
- 3cb646264e8c 12.0 cited
-
Use ARMv8 CRC instructions where available.
- f044d71e331d 11.0 cited
-
Logical replication support for initial data copy
- 7c4f52409a8c 10.0 cited
-
Use Intel SSE 4.2 CRC instructions where available.
- 3dc2d62d0486 9.5.0 cited
-
Switch to CRC-32C in WAL and other places.
- 5028f22f6eb0 9.5.0 cited
-
Remove support for 64-bit CRC.
- 404bc51cde9d 9.5.0 cited
-
Change CRCs in WAL records from 64bit to 32bit for performance reasons.
- 21fda22ec46d 8.1.0 cited
On Tue, 14 Apr 2020 12:56:49 -0400 Robert Haas <robertmhaas@gmail.com> wrote: > On Mon, Apr 13, 2020 at 5:43 PM Alvaro Herrera <alvherre@2ndquadrant.com> > wrote: > > Yeah, I guess I'm just saying that it feels brittle to have a file > > format that's supposed to be good for data exchange and then make it > > itself depend on representation details such as the order that fields > > appear in, the letter case, or the format of newlines. Maybe this isn't > > really of concern, but it seemed strange. > > I didn't want to use JSON for this at all, but I got outvoted. When I > raised this issue, it was suggested that I deal with it in this way, > so I did. I can't really defend it too far beyond that, although I do > think that one nice thing about this is that you can verify the > checksum using shell commands if you want. Just figure out the number > of lines in the file, minus one, and do head -n$LINES backup_manifest > | shasum -a256 and boom. If there were some whitespace-skipping thing > figuring out how to reproduce the checksum calculation would be hard. FWIW, shell commands (md5sum and sha*sum) read checksums from a separate file with a very simple format: one file per line with format "CHECKSUM FILEPATH". Thanks to json, it is fairly easy to extract checksums and filenames from the current manifest file format and check them all with one command: jq -r '.Files|.[]|.Checksum+" "+.Path' backup_manifest > checksums.sha256 sha256sum --check --quiet checksums.sha256 You can even pipe these commands together to avoid the intermediary file. But for backup_manifest, it's kind of shame we have to check the checksum against an transformed version of the file. Did you consider creating eg. a separate backup_manifest.sha256 file? I'm very sorry in advance if this has been discussed previously. Regards,