Re: doc review for parallel vacuum

Justin Pryzby <pryzby@telsasoft.com>

From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Mahendra Singh Thalor <mahi6run@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Sergei Kornilov <sk@zsrv.org>, pgsql-hackers@postgresql.org
Date: 2020-04-13T21:24:40Z
Lists: pgsql-hackers
On Mon, Apr 13, 2020 at 03:22:06PM +0530, Amit Kapila wrote:
> On Mon, Apr 13, 2020 at 2:00 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> >
> > |Copy the index
> > |bulk-deletion result returned from ambulkdelete and amvacuumcleanup to
> > |the DSM segment if it's the first time [???] because they allocate locally
> > |and it's possible that an index will be vacuumed by a different
> > |vacuum process the next time."
> >
> > Is it correct to say: "..if it's the first iteration" and "different process on
> > the next iteration" ?  Or "cycle" ?
> >
> 
> "cycle" sounds better.  I have changed the patch as per your latest
> comments.  Let me know what you think?

Looks good.  One more change:

[-Even if-]{+If+} this option is specified with the <option>ANALYZE</option> [-option-]{+option,+}

Remove "even" and add comma.

Thanks,
-- 
Justin



Commits

  1. Comments and doc fixes for commit 40d964ec99.