Re: pg_validatebackup -> pg_verifybackup?

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Steele <david@pgmasters.net>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2020-04-10T20:35:25Z
Lists: pgsql-hackers
Hi,

On 2020-04-10 16:13:18 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > FWIW, I still think it's a mistake to accumulate all these bespoke
> > tools. We should go towards having one tool that can verify checksums,
> > validate backup manifests etc. Partially because it's more discoverable,
> > but also because it allows to verify multiple such properties in a
> > single pass, rather than reading the huge base backup twice.
> 
> Well, we're not getting there for v13.  Are you proposing that this
> patch just be reverted because it doesn't do everything at once?

No. I suggest choosing a name that's compatible with moving more
capabilities under the same umbrella at a later time (and I suggested
the same pre freeze too). Possibly adding a toplevel --verify-manifest
option as the only change besides naming.

Andres



Commits

  1. Rename pg_validatebackup to pg_verifybackup some more.

  2. Rename pg_validatebackup to pg_verifybackup.