Horton

Re: doc review for v13

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org, Alexander Korotkov <a.korotkov@postgrespro.ru>
Date: 2020-04-10T06:29:02Z
Lists: pgsql-hackers 
On Thu, Apr 09, 2020 at 10:01:51PM -0500, Justin Pryzby wrote:
> On Fri, Apr 10, 2020 at 11:27:46AM +0900, Michael Paquier wrote:
>>  required pages to remove both downlink and rightlink are already  locked.  That
>> -evades potential right to left page locking order, which could deadlock with
>> +avoid potential right to left page locking order, which could deadlock with
>> Not sure which one is better, but the new change is grammatically
>> incorrect.
> 
> "Evades" usually means to act to avoid detection by the government.  Like tax
> evasion.

This change is from Alexander Korotkov as of 32ca32d, so I am adding
him in CC to get his opinion.

>>        <varname>auto_explain.log_settings</varname> controls whether information
>> -      about modified configuration options are printed when execution plan is logged.
>> -      Only options affecting query planning with value different from the built-in
>> +      about modified configuration options is printed when an execution plan is logged.
>> +      Only those options which affect query planning and whose value differs from its built-in
>> Depends on how you read the sentence, but here is seemt to me that 
>> "statistics" is the correct subject, no?
> 
> Statistics ?

Oops.  I may have messed up with a different part of the patch set.
Your suggestion is right as the subject is "information" here.
--
Michael

Commits

  1. Copy editing: fix a bunch of misspellings and poor wording.

  2. doc: Fix some grammar and inconsistencies

  3. Fix some comments referring to past features

  4. Fix typos and some format mistakes in comments

  5. Fix some typos

  6. Fix collection of typos and grammar mistakes in the tree, volume 2

  7. Rename pg_validatebackup to pg_verifybackup.

  8. Fix collection of typos and grammar mistakes in the tree