Horton

Re: doc review for v13

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2020-04-10T03:01:51Z
Lists: pgsql-hackers

Attachments

On Fri, Apr 10, 2020 at 11:27:46AM +0900, Michael Paquier wrote:
> On Wed, Apr 08, 2020 at 11:56:53AM -0500, Justin Pryzby wrote:
> > I previously mailed separately about a few individual patches, some of which
> > have separate, ongoing discussion and aren't included here (incr sort, parallel
> > vacuum).
> 
> I have gone through your changes, and committed what looked like the
> most obvious mistakes in my view.  Please see below for more
> comments.

Thanks - rebased for cfbot and continued review.

>  required pages to remove both downlink and rightlink are already  locked.  That
> -evades potential right to left page locking order, which could deadlock with
> +avoid potential right to left page locking order, which could deadlock with
> Not sure which one is better, but the new change is grammatically
> incorrect.

Thanks for noticing

"Evades" usually means to act to avoid detection by the government.  Like tax
evasion.

>        <varname>auto_explain.log_settings</varname> controls whether information
> -      about modified configuration options are printed when execution plan is logged.
> -      Only options affecting query planning with value different from the built-in
> +      about modified configuration options is printed when an execution plan is logged.
> +      Only those options which affect query planning and whose value differs from its built-in
> Depends on how you read the sentence, but here is seemt to me that 
> "statistics" is the correct subject, no?

Statistics ?

>      <literal>_tz</literal> suffix. These functions have been implemented to
> -    support comparison of date/time values that involves implicit
> +    support comparison of date/time values that involve implicit
> The subject is "comparison" here, no?

You're right.

-- 
Justin

Commits

  1. Copy editing: fix a bunch of misspellings and poor wording.

  2. doc: Fix some grammar and inconsistencies

  3. Fix some comments referring to past features

  4. Fix typos and some format mistakes in comments

  5. Fix some typos

  6. Fix collection of typos and grammar mistakes in the tree, volume 2

  7. Rename pg_validatebackup to pg_verifybackup.

  8. Fix collection of typos and grammar mistakes in the tree