Horton

Re: [BUG] non archived WAL removed during production crash recovery

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: jgdr@dalibo.com
Cc: michael@paquier.xyz, masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org
Date: 2020-04-10T02:14:54Z
Lists: pgsql-bugs, pgsql-hackers 
At Thu, 9 Apr 2020 18:46:22 +0200, Jehan-Guillaume de Rorthais <jgdr@dalibo.com> wrote in 
> On Wed, 8 Apr 2020 13:58:30 +0200
> Jehan-Guillaume de Rorthais <jgdr@dalibo.com> wrote:
> [...]
> > > May I ask why this new test is added to 011_crash_recovery.pl which is
> > > aimed at testing crash and redo, while we have 002_archiving.pl that
> > > is dedicated to archiving in a more general manner?  
> > 
> > I thought it was a better place because the test happen during crash recovery.
> > 
> > In the meantime, while working on other tests related to $SUBJECT and the
> > current consensus, I was wondering if a new file would be a better place
> > anyway.
> 
> So, 002_archiving.pl deals more with testing recovering on hot standby side
> than archiving. Maybe it could be renamed?

I have the same feeling with Michael.  The test that archives are
created correctly seems to fit the file.  It would be unintentionally
that the file is not exercising archiving so much.

> While discussing this, I created a new file to add some more tests about WAL
> archiving and how recovery deal with them. Please, find the patch in
> attachment. I'll be able to move them elsewhere later, depending on the
> conclusions of this discussion.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Fix interpolation in test name.

  2. Add more TAP coverage for archive status with crash recovery of standbys

  3. Fix handling of WAL segments ready to be archived during crash recovery

  4. Fix WAL recycling on standbys depending on archive_mode