Re: Drongo vs. 9.4 initdb TAP test

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Date: 2019-12-23T00:53:41Z
Lists: pgsql-hackers
On Sun, Dec 22, 2019 at 07:24:09PM -0500, Tom Lane wrote:
> This test is passing in the newer branches --- evidently due to
> the 9.5-era commit 1a629c1b1, which removed this TAP script's
> dependency on "rm -rf".  So we should either back-patch that
> commit into 9.4 or undo whatever configuration change caused
> drongo to try to run more tests.  I favor the former.

I would prefer simply removing the dependency of rm -rf in the tests,
even if that's for a short time as 9.4 is EOL in two months.  A
back-patch applies without conflicts, and the tests are able to pass.
Would you prefer doing it yourself?  I have not checked yet on
Windows, better to make sure that it does not fail.
--
Michael

Commits

  1. Combine initdb tests that successfully create a data directory.