Horton

Thread

Commits

  1. GetPublicationByName: Don't repeat ourselves

  1. pg_publication repetitious code

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2019-12-20T20:10:17Z

    This very small patch removes some duplicated code in pg_publication.

-- 
Álvaro Herrera                            http://www.linkedin.com/in/alvherre

  2. Re: pg_publication repetitious code

    Tom Lane <tgl@sss.pgh.pa.us> — 2019-12-20T20:54:05Z

    Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> This very small patch removes some duplicated code in pg_publication.

Seems like the extra test on missing_oid is unnecessary:

+	oid = get_publication_oid(pubname, missing_ok);
+	if (!OidIsValid(oid) && missing_ok)
+		return NULL;

As coded, it's get_publication_oid's job to deal with that.

Otherwise +1

			regards, tom lane