Horton

Re: automating pg_config.h.win32 maintenance

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-12-19T03:59:24Z
Lists: pgsql-hackers 
On Tue, Dec 17, 2019 at 11:56:17AM +0100, Peter Eisentraut wrote:
> Yeah, good idea.  Attached patch is refactored so all three header files
> managed by AC_CONFIG_HEADERS are processed the same way.

Looks good.  I just have one comment.

+   # XXX
+   open(my $f, '>>', 'src/include/pg_config.h')
+     || confess "Could not write to src/include/pg_config.h\n";
+   print $f "\n";
+   print $f "#define VAL_CONFIGURE \""
+     . $self->GetFakeConfigure() . "\"\n";
+   close($f);

This part needs a comment.  Like it is the equivalent of what
src/common/'s Makefile does or something like that?
--
Michael

Commits

  1. Generate pg_config.h from pg_config.h.in on Windows