Re: REINDEX CONCURRENTLY unexpectedly fails
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Manuel Rigger <rigger.manuel@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-12-13T02:47:33Z
Lists: pgsql-bugs
On Thu, Dec 12, 2019 at 05:11:08PM -0300, Alvaro Herrera wrote: > I liked Andres' original naming suggestion better FWIW. With this, one > wonders "concurrently what?" I did not like the "creation" part from the original suggestion :) IndexCreationSupportsConcurrent() called from a place where an index is dropped does not sound very consistent. > Some suggestions, > "RelationSupportsConcurrentIndexing" or > "IndexSupportsConcurrently". Maybe replace the "ing" in the first or > "ly" in the second with "DDL" or "Ops". (Also, if it's just about > indexes and appears in index.h, why did you use the prefix "Relation"?) RelationSupportsConcurrentIndexing sounds like a good compromise to me. The reasoning behind using relation is that this check can be used for an index or its parent relation. -- Michael
Commits
-
Fix concurrent indexing operations with temporary tables
- d76652edc56f 9.4.26 landed
- c39f45598177 9.5.21 landed
- ef33edeb5835 9.6.17 landed
- 9055344b495f 10.12 landed
- 5b4b07fa9ac3 11.7 landed
- 817a1b88ac66 12.2 landed
- a904abe2e284 13.0 landed