Re: [Proposal] Level4 Warnings show many shadow vars

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>

To: Ranier Vilela <ranier_gyn@hotmail.com>

Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2019-12-11T15:19:08Z

Lists: pgsql-hackers

Greetings,

* Ranier Vilela (ranier_gyn@hotmail.com) wrote:
> New version the global patch unshadow.
> * names more consistent and readable.
> * without big changes.
> * goal,, unshadow all global variables, only, even the simplest.

This didn't address any of the comments that I raised elsewhere on this
thread...  I certainly don't like the changes being proposed here for
pg_dump.

Thanks,

Stephen

Commits

Remove shadow variables linked to RedoRecPtr in xlog.c
- 668365014d7b 11.7 landed
- 35c01529b8c9 12.2 landed
- 70116493a8e0 13.0 landed
Fix calculation for WAL segment recycling and removal
- d9fadbf13103 12.0 cited