Re: log bind parameter values on error

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Alexey Bashtanov <bashtanov@imap.cc>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-12-09T20:05:31Z
Lists: pgsql-hackers
Also:

* Thoughts from Andres, who was busily messing about with stringinfo.c
  on his patch series for programmatic out/read node functions?

* Thoughts on changing the current usage of the ...Quoted() function in
  postgres.c and pl_exec.c so that they print N characters (64) instead
  of the current default of printing everything?  I'm up for changing,
  but have got no +1s on that.  I think bloating log files with enormous
  parameters is pointless.

* v18 and v19 now alwys do a "strlen(s)", i.e. they scan the whole input
  string -- pointless when maxlen is given.  We could avoid that for
  very large input strings by doing strnlen(maxlen + MAX_MULTIBYTE_CHAR_LEN)
  so that we capture our input string plus one additional multibyte
  char.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Emit parameter values during query bind/execute errors

  2. Add backend-only appendStringInfoStringQuoted