Re: Increase footprint of %m and reduce strerror()
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-12-05T02:36:48Z
Lists: pgsql-hackers
On Wed, Dec 04, 2019 at 03:32:11PM +0900, Kyotaro Horiguchi wrote: > It sounds good to me. Message unification (including printf) needs > somehow treating trailing new lines, though. About translation > burden, I'm not sure how the message unification eases translators' > work. Identical messages of different commands appear having different > neighbours in different po files. Newlines are a problem. Still there are cases where we don't use them. See for example pg_waldump.c. It seems like it would be first interesting to fix the code paths where we know we can reduce the duplicates. > By the way aren't we going to have ereport on frontend? Not sure that this will happen, there are quite a few things to consider related to what error hints and such should be for frontends. That's quite a different discussion.. -- Michael
Commits
-
Replace use of strerror() with %s by %m in pg_waldump
- cce64a51cabc 13.0 landed
-
Implement %m in src/port/snprintf.c, and teach elog.c to rely on that.
- d6c55de1f99a 12.0 cited