Re: Failure in TAP tests of pg_ctl on Windows with parallel instance set
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-12-03T04:03:01Z
Lists: pgsql-hackers
On Mon, Dec 02, 2019 at 07:57:31AM -0500, Andrew Dunstan wrote: > Looks reasonable. Thanks, committed and back-patched down to 11, which is where we have PostgresNode::get_free_port. This could go further down with more refactoring of PostgresNode.pm but as it took a long time to find this issue that does not seem really worth the extra legwork. > I wonder if there are other test sets where we need to set the port. I looked at that before sending the first email, with the tests of initdb and pg_basebackup potentially breaking stuff, but we never initialize (direct initdb) and then start a node without PostgresNode.pm. So we are fine as far as I saw. -- Michael
Commits
-
Fix failures with TAP tests of pg_ctl on Windows
- 8fd28a7baacc 11.7 landed
- ef30975b4970 12.2 landed
- e5532f194c18 13.0 landed