Horton

Re: pg_waldump and PREPARE

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: btkimurayuzk <btkimurayuzk@oss.nttdata.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Andrey Lepikhov <a.lepikhov@postgrespro.ru>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>
Date: 2019-11-20T08:50:07Z
Lists: pgsql-hackers 
On Wed, Nov 20, 2019 at 04:16:45PM +0900, btkimurayuzk wrote:
>  typedef struct xl_xact_relfilenodes
>  {
> -	int			nrels;			/* number of subtransaction XIDs */
> +	int			nrels;			/* number of relations */
>  	RelFileNode xnodes[FLEXIBLE_ARRAY_MEMBER];
>  } xl_xact_relfilenodes;
>  #define MinSizeOfXactRelfilenodes offsetof(xl_xact_relfilenodes, xnodes)

These are relations, and it smells like a copy-pasto coming from
xl_xact_subxacts.  Thanks Kimura-san, committed. 
--
Michael

Commits

  1. Fix comment in xact.h

  2. Make pg_waldump report more detail information about PREPARE TRANSACTION record.

  3. Store 2PC GID in commit/abort WAL recs for logical decoding