Re: SKIP_LOCKED test causes random buildfarm failures
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org
Date: 2019-11-15T01:19:20Z
Lists: pgsql-hackers
On Thu, Nov 14, 2019 at 03:20:09PM -0500, Tom Lane wrote: > If we're going to keep them in vacuum.sql, we should use the > client_min_messages fix there, as that's a full solution not just > reducing the window. But I don't agree that these tests are worth > the cycles, given the coverage elsewhere. The probability of breaking > this option is just not high enough to justify core-regression-test > coverage. I would rather keep the solution with client_min_messages, and the tests in vacuum.sql to keep those checks for the grammar parsing. So this basically brings us back to use the patch I proposed here: https://www.postgresql.org/message-id/20191107013942.GA1768@paquier.xyz Any objections? -- Michael
Commits
-
Improve stability of tests for VACUUM (SKIP_LOCKED)
- bbaa38e82423 12.2 landed
- 3db0598d908f 13.0 landed