Horton

Re: [PATCH] Do not use StdRdOptions in Access Methods

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: pgsql-hackers@lists.postgresql.org, Amit Langote <amitlangote09@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dent John <denty@qqdd.eu>, Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "Iwata, Aya" <iwata.aya@jp.fujitsu.com>, Dmitry Dolgov <9erthalion6@gmail.com>
Date: 2019-11-14T07:50:18Z
Lists: pgsql-hackers 
On Wed, Nov 13, 2019 at 04:26:53PM +0300, Nikolay Shaplov wrote:
> I've changed the patch to use build_reloptions function and again propose it 
> to the commitfest.

Thanks for the new patch.  I have not reviewed the patch in details,
but I have a small comment.

> +#define SpGistGetFillFactor(relation) \
> +	((relation)->rd_options ? \
> +		((SpGistOptions *) (relation)->rd_options)->fillfactor : \
> +		SPGIST_DEFAULT_FILLFACTOR)
> +
Wouldn't it make sense to add assertions here to make sure that the
relkind is an index?  You basically did that in commit 3967737.
--
Michael

Commits

  1. Refactor reloption handling for index AMs in-core

  2. Cleanup code in reloptions.h regarding reloption handling

  3. Refactor code building relation options

  4. Add some assertions to view reloption macros