Horton

Re: [BUG FIX] Uninitialized var fargtypes used.

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: tgl@sss.pgh.pa.us
Cc: alvherre@2ndquadrant.com, ranier_gyn@hotmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-11-13T00:38:28Z
Lists: pgsql-bugs 
At Tue, 12 Nov 2019 11:07:10 -0500, Tom Lane <tgl@sss.pgh.pa.us> wrote in 
> The argument for changing the code like this seems to be "we'll
> assume the possibility of a bug/corruption is so small that it's
> okay to treat it as a user mistake".  I reject that line of thinking.

Ah, understood.

> And I especially reject conflating the two cases without bothering
> to fix the adjacent comment that describes only case 1.

Mm. I should be more careful..

Anyway thanks for fixing this!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Finish reverting commit 0a52d378b.

  2. Have LookupFuncName accept NULL argtypes for 0 args

  3. Avoid passing NULL to memcmp() in lookups of zero-argument functions.