Horton

Re: pg_waldump and PREPARE

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Andrey Lepikhov <a.lepikhov@postgrespro.ru>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>
Date: 2019-11-12T09:03:30Z
Lists: pgsql-hackers 
On Tue, Nov 12, 2019 at 05:53:02PM +0900, Fujii Masao wrote:
> Thanks for the review! But probably I failed to understand your point...
> Could you clarify what actual change is necessary? You are thinking that
> the check of "parsed.nmsgs >= 0" should be moved to the inside of
> standby_desc_invalidations()?

Yes that's what I meant here.
--
Michael

Commits

  1. Fix comment in xact.h

  2. Make pg_waldump report more detail information about PREPARE TRANSACTION record.

  3. Store 2PC GID in commit/abort WAL recs for logical decoding