Horton

Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Gilles Darold <gilles@darold.net>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-09T01:22:51Z
Lists: pgsql-hackers 
On Fri, Nov 08, 2019 at 10:19:01AM +0100, Gilles Darold wrote:
> I don't think so. The support or not of 2PC is on foreign data wrapper
> side. In postgres_fdw contrib the error for use with 2PC is not part of
> the test but it will be thrown anyway. I guess that a test will be
> valuable only if there is support for readonly query.

That's what I call a case for negative testing.  We don't allow 2PC to
be used so there is a point in having a test to make sure of that.
This way, if the code in this area is refactored or changed, we still
make sure that 2PC is correctly prevented.  My suggestion is to close
this gap.  One point here is that this requires an alternate output
file because of max_prepared_transactions and there is no point in
creating one with all the tests of postgres_fdw in a single file as we
have now as it would create 8k lines of expected file bloat, so it
would be better to split the tests first.  My 2c.
--
Michael

Commits

  1. Add regression test for two-phase transaction in postgres_fdw

  2. postgres_fdw: Fix error message for PREPARE TRANSACTION.