Re: heapam_index_build_range_scan's anyvisible

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>, Alvaro Herrera <alvherre@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-08T09:22:45Z
Lists: pgsql-hackers
Hi,

On 2019-11-07 09:25:40 -0800, Andres Freund wrote:
> On 2019-11-07 17:02:36 +0900, Michael Paquier wrote:
> > On Wed, Sep 25, 2019 at 10:24:05PM -0700, Ashwin Agrawal wrote:
> > > Thanks for reporting, I did indeed missed out contrib. Please find attached
> > > the v2 of the patch which includes the change required in contrib as well.
> > 
> > Okay, that makes sense.  The patch looks good to me so I have switched
> > it to ready for committer.  Andres, Robert, would you prefer
> > committing this one yourself?  If not, I'll take care of it tomorrow
> > after a second look.
> 
> Let me take a look this afternoon. Swapped out of my brain right now
> unfortunately.

Looks good to me (minus a formatting change in one or two places,
undoing linebreaks). I was about to push, but after trying to write a
sentence in the commit message like three times, I'instead push first
thing tomorrow..

Greetings,

Andres Freund



Commits

  1. Pass ItemPointer not HeapTuple to IndexBuildCallback.

  2. Fix BRIN to use SnapshotAny during summarization