Horton

Re: pg_waldump and PREPARE

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: a.lepikhov@postgrespro.ru
Cc: masao.fujii@gmail.com, michael@paquier.xyz, alvherre@2ndquadrant.com, thomas.munro@gmail.com, rjuju123@gmail.com, pgsql-hackers@postgresql.org, vignesh21@gmail.com
Date: 2019-11-08T04:26:18Z
Lists: pgsql-hackers 
Hello.

At Fri, 8 Nov 2019 08:23:41 +0500, Andrey Lepikhov <a.lepikhov@postgrespro.ru> wrote in 
> > Can I switch the status back to "Needs review"?
> > Regards,
> > 
> 
> One issue is that your patch provides small information. WAL errors
> Investigation often requires information on xid, subxacts,
> delete-on-abort/commit rels; rarely - invalidation messages etc.

Basically agrred, but it can be very large in certain cases, even if
it is rare.

By the way, in the patch xact_desc_prepare seems printing
parseed.xact_time, which is not actually set by ParsePrepareRecord.

# I missed the funtion. xl_xact_prepare is used in *two* places in
# front end.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Fix comment in xact.h

  2. Make pg_waldump report more detail information about PREPARE TRANSACTION record.

  3. Store 2PC GID in commit/abort WAL recs for logical decoding