Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: etsuro.fujita@gmail.com
Cc: michael@paquier.xyz, gilles@darold.net,
pgsql-hackers@lists.postgresql.org
Date: 2019-11-07T08:27:47Z
Lists: pgsql-hackers
Hello, Fujita-san. At Thu, 7 Nov 2019 17:20:07 +0900, Etsuro Fujita <etsuro.fujita@gmail.com> wrote in > Only two people complaining about the wording? Considering as well > that we use that wording in the docs and there were no complains about > that IIRC, I don't feel a need to change that, TBH. > > > And perhaps "prepare" should be in > > upper case letters. > > Seems like a good idea. > > > Plus, any operation including a SELECT on a > > temporary table inhibits PREAPRE TRANSACTION, but the same on a > > postgres_fdw foreign tables is not. So the error message is rather > > wrong. > > > > A verbose alternative can be: > > > > "cannot PREPARE a transaction that has modified data on foreign tables using postgres_fdw" > > I don't think that's better, because that doesn't address the original > issue reported in this thread, as Gilles pointed out just before in > his email. See the commit message in the patch I posted. "modified" is my mistake as in the just posted mail. But the most significant point in the previous mail is using "foreign tables using postgres_fdw" instead of "postgres_fdw foreign tables". And the other point is using different message from temporary tables. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Add regression test for two-phase transaction in postgres_fdw
- 94fec48516a7 13.0 landed
-
postgres_fdw: Fix error message for PREPARE TRANSACTION.
- 1bd67d535843 9.4.25 landed
- b260ce9c19b6 9.5.20 landed
- bca0aed2d01c 9.6.16 landed
- 0c7a28a5eabd 10.11 landed
- 042e82cef949 11.6 landed
- 0cc31cc32da0 12.1 landed
- 879c11761571 13.0 landed