Horton

Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Gilles Darold <gilles@darold.net>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-06T07:35:10Z
Lists: pgsql-hackers 
On Wed, Nov 06, 2019 at 03:12:04PM +0900, Etsuro Fujita wrote:
> On Wed, Nov 6, 2019 at 1:13 PM Michael Paquier <michael@paquier.xyz> wrote:
>> "postgres_fdw foreign tables" sounds weird to me.  Could "foreign
>> tables using postgres_fdw" be a better wording?  I am wondering as
>> well if we should not split this information into two parts: one for
>> the actual error message which only mentions foreign tables, and a
>> second one with a hint to mention that postgres_fdw has been used.
> 
> We use "postgres_fdw foreign tables" or "postgres_fdw tables" in
> release notes, so I thought it was OK to use that in error messages as
> well.  But actually, these wordings are not suitable for error
> messages?

It is true that the docs of postgres_fdw use that and that it is used
in some comments.  Still, I found this wording a bit weird..  If you
think that what you have is better, I am also fine to let you have the 
final word, so please feel to ignore me :)
--
Michael

Commits

  1. Add regression test for two-phase transaction in postgres_fdw

  2. postgres_fdw: Fix error message for PREPARE TRANSACTION.