Re: v12 and pg_restore -f-
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, "imai.yoshikazu@fujitsu.com" <imai.yoshikazu@fujitsu.com>, Euler Taveira <euler@timbira.com.br>, Andrew Gierth <andrew@tao11.riddles.org.uk>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-05T15:00:35Z
Lists: pgsql-hackers, pgsql-general
Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost <sfrost@snowman.net> writes: > > * Tom Lane (tgl@sss.pgh.pa.us) wrote: > >> In this case, not in the least: we would simply be imposing the sort > >> of *orderly* feature introduction that I thought was the plan from > >> the very beginning [1]. That is, first make "-f -" available, and > >> make it required only in some later version. If we'd back-patched > >> the optional feature back in April, it might've been okay to require > >> it in v12, but we failed to provide any transition period. > > > ... just like we didn't provide any transistion period for the > > recovery.conf changes. > > Sure, because there wasn't any practical way to provide a transition > period. I think that case is entirely not comparable to this one, > either as to whether a transition period is possible, or as to whether > the benefits of the change merit forced breakage. We didn't put any effort into trying to provide a transition period, and for good reason- everyone gets 5 years of transition time. I'd be just as happy to not even commit the change to make -f- go to stdout in the back-branches, if I didn't feel that the behavior of it going to a file called ./- was really just an outright bug in the first place. Thanks, Stephen
Commits
-
Change pg_restore -f- to dump to stdout instead of to ./-
- 5ee8f0fe13b4 10.11 landed
- d38635725cad 9.5.20 landed
- 12a51e2ebea7 9.6.16 landed
- 9fb25fda6d56 9.4.25 landed
- 3574c0ac0509 11.6 landed