Horton

Re: [PATCH] Do not use StdRdOptions in Access Methods

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>, Dent John <denty@qqdd.eu>, Thomas Munro <thomas.munro@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "Iwata, Aya" <iwata.aya@jp.fujitsu.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dmitry Dolgov <9erthalion6@gmail.com>
Date: 2019-11-05T00:22:20Z
Lists: pgsql-hackers 
On Thu, Oct 31, 2019 at 05:55:55PM +0900, Michael Paquier wrote:
> Thanks.  I exactly did the same thing on my local branch.

Hearing nothing more, I have done some adjustments to the patch and
committed it.  Please note that I have not switched the old interface
to be static to reloptions.c as if you look closely at reloptions.h we
allow much more flexibility around HANDLE_INT_RELOPTION to fill and
parse the reloptions in custom AM.  AM maintainers had better use the
new interface, but there could be a point for more customized error
messages.
--
Michael

Commits

  1. Refactor reloption handling for index AMs in-core

  2. Cleanup code in reloptions.h regarding reloption handling

  3. Refactor code building relation options

  4. Add some assertions to view reloption macros