Horton

Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-10-31T09:07:34Z
Lists: pgsql-hackers 
On Mon, Oct 28, 2019 at 10:56:33PM -0500, Justin Pryzby wrote:
> I suppose it should something other than partition(ed), since partitions can be
> partitioned, too...
> 
>       Attaching a partition acquires a <literal>SHARE UPDATE EXCLUSIVE</literal>
>       lock on the parent table, in addition to
>       <literal>ACCESS EXCLUSIVE</literal> locks on the child table and the
>       <literal>DEFAULT</literal> partition (if any).

In this context, "on the child table" sounds a bit confusing?  Would
it make more sense to say the "on the table to be attached" instead?
--
Michael

Commits

  1. Doc: Clarify locks taken when using ALTER TABLE ATTACH PARTITION

  2. Doc: Improve description around ALTER TABLE ATTACH PARTITION